Change mutable default arguments to None
#6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwroblew
force-pushed
the
fix_default_list
branch
from
279e948 to
ed700f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #6376 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 393 393
Lines 21563 21563
=======================================
Hits 18227 18227
Misses 3336 3336 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
reviewed
Jan 9, 2023
rusty1s
changed the title
None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading PyG code I accidently saw that class and noticed that it uses mutable default arguments what is generally considered a bad practice and can lead to a lot of problems. I believe it's not a desired behaviour (am I wrong?).
Problems can occur when the class is extended in the future such that it changes the value of any of those lists, the default value for new instances of this class would also be affected. The other possibility is that user changes any of the
follow_batch,exclude_keysfields (those doesn't start with an underscore, so it's kinda possible) after the object is initialized, what's also going to change the default value for new instances.